Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smassh: init at 3.1.3 #302618

Merged
merged 2 commits into from
Apr 15, 2024
Merged

smassh: init at 3.1.3 #302618

merged 2 commits into from
Apr 15, 2024

Conversation

AimPizza
Copy link
Contributor

@AimPizza AimPizza commented Apr 8, 2024

Description of changes

Smassh is a TUI based typing test application inspired by MonkeyType

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Apr 8, 2024
@lovesegfault
Copy link
Member

Please rebase/squash your changes, if possible

pkgs/by-name/sm/smassh/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sm/smassh/package.nix Outdated Show resolved Hide resolved
@MikaelFangel
Copy link
Contributor

A technicality but the commit adding you as a maintainer needs to come before the package commit (:

@AimPizza
Copy link
Contributor Author

We'll get there eventually 😁
Thank you everybody being so patient and helpful!

@lovesegfault lovesegfault merged commit 51e2bd4 into NixOS:master Apr 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants